Commit graph

1266 commits

Author SHA1 Message Date
Arthur Schiwon 7d7d56c0ca bump backend version and drop support for old Nextcloud releases
- also fixes some logic errors and deprecations
- GroupBackend can now implement INamedBackend

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-09-23 22:02:00 +00:00
Giuliano Mele 49aa594874 Fix phpunit xml file
Signed-off-by: Giuliano Mele <giuliano.mele@verdigado.com>
2022-09-23 21:47:26 +00:00
Giuliano Mele fbc5c9b519 Fix php code styles
Signed-off-by: Giuliano Mele <giuliano.mele@verdigado.com>
2022-09-23 21:47:26 +00:00
Giuliano Mele c36d4b8632 Fix php unit tests
- Switch to new configuration setup, see #558

Signed-off-by: Giuliano Mele <giuliano.mele@verdigado.com>
2022-09-23 21:47:26 +00:00
Giuliano Mele 50da9dbc3f Add copyrights
Signed-off-by: Giuliano Mele <giuliano.mele@verdigado.com>
2022-09-23 21:47:26 +00:00
Giuliano Mele 2146ac3688 Update appinfo/app.php
Co-authored-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Giuliano Mele <giuliano.mele@verdigado.com>
2022-09-23 21:47:26 +00:00
Giuliano Mele aa767344ff Fix query SAML settings
Signed-off-by: Giuliano Mele <giuliano.mele@verdigado.com>
2022-09-23 21:47:26 +00:00
Giuliano Mele 26ee76cd55 Fix service registration closure parameters
Signed-off-by: Giuliano Mele <giuliano.mele@verdigado.com>
2022-09-23 21:47:26 +00:00
Jonathan Treffler 6745787608 Update lib/UserBackend.php
Co-authored-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Giuliano Mele <giuliano.mele@verdigado.com>
2022-09-23 21:47:26 +00:00
Jonathan Treffler c27e643c0f Update lib/Jobs/MigrateGroups.php
Co-authored-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Giuliano Mele <giuliano.mele@verdigado.com>
2022-09-23 21:47:26 +00:00
Jonathan Treffler 8914615ef8 Update lib/Jobs/MigrateGroups.php
Co-authored-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Giuliano Mele <giuliano.mele@verdigado.com>
2022-09-23 21:47:26 +00:00
Jonathan Treffler 4c190ec40c Update lib/GroupDuplicateChecker.php
Co-authored-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Giuliano Mele <giuliano.mele@verdigado.com>
2022-09-23 21:47:26 +00:00
Jonathan Treffler 266e959a85 Update lib/GroupDuplicateChecker.php
Co-authored-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Giuliano Mele <giuliano.mele@verdigado.com>
2022-09-23 21:47:26 +00:00
Jonathan Treffler 3121e6c680 Update lib/GroupDuplicateChecker.php
Co-authored-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Giuliano Mele <giuliano.mele@verdigado.com>
2022-09-23 21:47:26 +00:00
Jonathan Treffler dfdd465a2a Update appinfo/app.php
Co-authored-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Giuliano Mele <giuliano.mele@verdigado.com>
2022-09-23 21:47:26 +00:00
Jonathan Treffler 3991763a65 Update appinfo/app.php
Co-authored-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Giuliano Mele <giuliano.mele@verdigado.com>
2022-09-23 21:47:26 +00:00
Giuliano Mele 1b6cd24a21 Revert "Append SAML_ prefix to groups"
This reverts commit 48f331ff32.

Signed-off-by: Giuliano Mele <giuliano.mele@verdigado.com>
2022-09-23 21:47:26 +00:00
Giuliano Mele e380b24720 Add SAML prefix to migration
Signed-off-by: Giuliano Mele <giuliano.mele@verdigado.com>
2022-09-23 21:47:26 +00:00
Giuliano Mele a40e812512 Append SAML_ prefix to groups
Signed-off-by: Giuliano Mele <giuliano.mele@verdigado.com>
2022-09-23 21:47:26 +00:00
Jonathan Treffler 5f3a68e0cd Update lib/GroupManager.php
Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>

Co-authored-by: Carl Schwan <carl@carlschwan.eu>
2022-09-23 21:47:26 +00:00
Jonathan Treffler b4232fd4ea Apply suggestions from code review by @CarlSchwan
Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>

Co-authored-by: Carl Schwan <carl@carlschwan.eu>
2022-09-23 21:47:26 +00:00
Jonathan Treffler 65e632a9dd Update lib/GroupManager.php
Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>

Co-authored-by: Carl Schwan <carl@carlschwan.eu>
2022-09-23 21:47:26 +00:00
Jonathan Treffler eca9e26e39 Update lib/GroupManager.php
Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>

Co-authored-by: Carl Schwan <carl@carlschwan.eu>
2022-09-23 21:47:26 +00:00
Jonathan Treffler d6b46bf055 Update lib/GroupManager.php
Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>

Co-authored-by: Carl Schwan <carl@carlschwan.eu>
2022-09-23 21:47:26 +00:00
Jonathan Treffler c8151717b3 Update lib/GroupManager.php
Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>

Co-authored-by: Carl Schwan <carl@carlschwan.eu>
2022-09-23 21:47:26 +00:00
Jonathan Treffler 78868b4773 Update lib/GroupManager.php
Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>

Co-authored-by: Carl Schwan <carl@carlschwan.eu>
2022-09-23 21:47:26 +00:00
Jonathan Treffler 19e55ce743 Update lib/GroupManager.php
Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>

Co-authored-by: Carl Schwan <carl@carlschwan.eu>
2022-09-23 21:47:26 +00:00
Jonathan Treffler 4f3a5c72e9 Update lib/GroupManager.php
Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>

Co-authored-by: Carl Schwan <carl@carlschwan.eu>
2022-09-23 21:47:26 +00:00
Jonathan Treffler cbd0d18c02 Update lib/GroupManager.php
Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>

Co-authored-by: Carl Schwan <carl@carlschwan.eu>
2022-09-23 21:47:26 +00:00
Jonathan Treffler 662bcd0f73 Update lib/GroupDuplicateChecker.php
Co-authored-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
2022-09-23 21:47:26 +00:00
Jonathan Treffler d162d92a01 Update lib/GroupManager.php
Co-authored-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
2022-09-23 21:47:25 +00:00
Giuliano Mele 5c0bec0280 Fix user backend unit tests
Signed-off-by: Giuliano Mele <giuliano.mele@verdigado.com>
2022-09-23 21:47:25 +00:00
Giuliano Mele 27a1a69b60 Fix unit tests
Signed-off-by: Giuliano Mele <giuliano.mele@verdigado.com>
2022-09-23 21:47:25 +00:00
Giuliano Mele 80a53e53ba Fix app code check compatibility 21
Signed-off-by: Giuliano Mele <giuliano.mele@verdigado.com>
2022-09-23 21:47:25 +00:00
Giuliano Mele 9deba64f14 Register repair step for group migrations
Signed-off-by: Giuliano Mele <giuliano.mele@verdigado.com>
2022-09-23 21:47:25 +00:00
Giuliano Mele e6effba008 Ensure admin cannot unassign SAML groups/members
Co-authored-by: Jonathan Treffler <mail@jonathan-treffler.de>
Co-authored-by: Giuliano Mele <giuliano.mele@verdigado.com>
Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
Signed-off-by: Giuliano Mele <giuliano.mele@verdigado.com>
2022-09-23 21:47:25 +00:00
Giuliano Mele 65006775e4 Nextcloud 21 support
- Group getBackendNames removed, is introduced in nextcloud 22
- QueryBuilder executeStatement and executeQuery replaced by execute function

Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
Signed-off-by: Giuliano Mele <giuliano.mele@verdigado.com>
2022-09-23 21:47:25 +00:00
Giuliano Mele aac68c1866 Adds group backend integration tests
Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
Signed-off-by: Giuliano Mele <giuliano.mele@verdigado.com>
2022-09-23 21:47:25 +00:00
Giuliano Mele efc1a68687 Update group manager unit test
Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
Signed-off-by: Giuliano Mele <giuliano.mele@verdigado.com>
2022-09-23 21:47:25 +00:00
Giuliano Mele ae7528fa55 Delete SAML groups without members
Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
Signed-off-by: Giuliano Mele <giuliano.mele@verdigado.com>
2022-09-23 21:47:25 +00:00
Giuliano Mele 49bc11c4e2 Create new SAML group on gid collision
Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
Signed-off-by: Giuliano Mele <giuliano.mele@verdigado.com>
2022-09-23 21:47:25 +00:00
Giuliano Mele c43453e821 Adds unit tests for group manager
Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
Signed-off-by: Giuliano Mele <giuliano.mele@verdigado.com>
2022-09-23 21:47:25 +00:00
Giuliano Mele 368195f03b Sync user backend test
Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
Signed-off-by: Giuliano Mele <giuliano.mele@verdigado.com>
2022-09-23 21:47:25 +00:00
Giuliano Mele 266a2f4467 Only remove user groups from SAML backend
Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
Signed-off-by: Giuliano Mele <giuliano.mele@verdigado.com>
2022-09-23 21:47:25 +00:00
Giuliano Mele e90aca0a23 Use builtin user group ids getter
Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
Signed-off-by: Giuliano Mele <giuliano.mele@verdigado.com>
2022-09-23 21:47:25 +00:00
Giuliano Mele 68f76b66c7 Gid collision: append SAML prefix to gid
Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
Signed-off-by: Giuliano Mele <giuliano.mele@verdigado.com>
2022-09-23 21:47:25 +00:00
Giuliano Mele 5752511ff8 Implement backend remove user from group method
Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
Signed-off-by: Giuliano Mele <giuliano.mele@verdigado.com>
2022-09-23 21:47:25 +00:00
Giuliano Mele 0b62b91a89 Fix bugs related to unit tests
Fix unit test errors
Fix admin unit test failure
Fix group to id translation

Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
Signed-off-by: Giuliano Mele <giuliano.mele@verdigado.com>
2022-09-23 21:47:25 +00:00
Giuliano Mele c5ff4555a3 Implement backends add user to groups method
Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
Signed-off-by: Giuliano Mele <giuliano.mele@verdigado.com>
2022-09-23 21:47:25 +00:00
Giuliano Mele 993529ed30 Fixes minor bugs
Fix missing constructor parameters
Fixes type error
Fix unimplemented IGroup interface
Fix group backend detection

Signed-off-by: Jonathan Treffler <mail@jonathan-treffler.de>
Signed-off-by: Giuliano Mele <giuliano.mele@verdigado.com>
2022-09-23 21:47:25 +00:00